#4399 Fix config install for hooks - #4412
Merged
Merged
Conversation
- .git folder is checked twice and all files from source folder are skipped. Since .git folder is verified by _process_folder, we dont need to check again, just copy all file from source to target as done for profile. - add unit test to check copy tree behavior Signed-off-by: Uilian Ries <uilianries@gmail.com>
- Copy file and subdir from hooks - Update functional test to check hooks folder - Update unit test for hooks folder Signed-off-by: Uilian Ries <uilianries@gmail.com>
- Skip .git folder when copying hooks - Update functional and unit test to validate .git folder case - Apply PEP8 format (yaml) Signed-off-by: Uilian Ries <uilianries@gmail.com>
danimtb
approved these changes
Jan 29, 2019
danimtb
left a comment
Member
There was a problem hiding this comment.
👍
The code formatting makes a little bit difficult to read the diff
Member
Author
|
My fault, I should postponed pep8 |
memsharded
approved these changes
Jan 29, 2019
memsharded
left a comment
Member
There was a problem hiding this comment.
I think can be merged, but please @uilianries have a look at the style comments.
Member
Author
|
TIL: We need to specify a code format file. 😅 |
SSE4
reviewed
Jan 29, 2019
Contributor
|
The release is two days late already, please review the styling comments asap if not done already. Everything not merged tomorrow morning won't be included. |
memsharded
approved these changes
Jan 30, 2019
Member
|
I have reverted most of the formatting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.git folder is checked twice when installing hooks and all files from source folder are skipped (bug). Since .git folder is verified by _process_folder,
we dont need to check it again, just copy all files from source to target folder
as done for profile.
I've added an unit test to check copy tree behavior. Is there a possible functional test to be added?
fixes #4399
Changelog: Bugfix: Fixes config install when copying hooks
Docs: omit
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.