JSON output for create and install commands with multi_config cpp_info - #4656
Merged
Merged
Conversation
Contributor
|
The duplicated information has to be discussed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: JSON output for
multi_confignow works ininstallandcreatecommandsDocs: omit
closes #4606
This PR fixes an error when trying to build the JSON output with a multi_config cpp_info, the custom json-handler written with dates in mind wasn't working properly when a
CppInfowas to be dumped into json format.It doesn't modify the output, it just dumps the information contained in the
CppInfoobject. The test emphasizes the duplicated information (default directories androotpath) and the empty directory that is present in the output (builddirs). (Note.- This output is different from the one in the json generator, in that generator non-existing paths are being discarded and the output nodes are different:*_paths).Full JSON in the test implemented is as follows:
{ "error": false, "installed": [ { "recipe": { "id": "name/version@user/channel", "downloaded": false, "exported": true, "error": null, "remote": null, "time": "2019-03-05T09:50:27.598141", "dependency": false, "name": "name", "version": "version", "user": "user", "channel": "channel" }, "packages": [ { "id": "5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9", "downloaded": false, "exported": false, "error": null, "remote": null, "time": "2019-03-05T09:50:28.138290", "built": true, "cpp_info": { "includedirs": [ "include" ], "libdirs": [ "lib" ], "resdirs": [ "res" ], "bindirs": [ "bin" ], "builddirs": [ "" ], "rootpath": "/private/var/folders/yq/14hmvxm96xd7gfgl37_tnrbh0000gn/T/tmpqh89_yjyconans/path with spaces/.conan/data/name/version/user/channel/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9", "version": "version", "filter_empty": true, "configs": { "release": { "includedirs": [ "include" ], "libdirs": [ "lib" ], "resdirs": [ "res" ], "bindirs": [ "bin" ], "builddirs": [ "" ], "libs": [ "hello" ], "rootpath": "/private/var/folders/yq/14hmvxm96xd7gfgl37_tnrbh0000gn/T/tmpqh89_yjyconans/path with spaces/.conan/data/name/version/user/channel/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9", "filter_empty": true }, "debug": { "includedirs": [ "include" ], "libdirs": [ "lib-debug" ], "resdirs": [ "res" ], "bindirs": [ "bin" ], "builddirs": [ "" ], "libs": [ "hello_d" ], "rootpath": "/private/var/folders/yq/14hmvxm96xd7gfgl37_tnrbh0000gn/T/tmpqh89_yjyconans/path with spaces/.conan/data/name/version/user/channel/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9", "filter_empty": true } } } } ] } ] }