conan_basic_setup() same interface for cmake_multi - #4721
Merged
Merged
Conversation
memsharded
reviewed
Mar 12, 2019
danimtb
marked this pull request as ready for review
March 13, 2019 15:28
This was referenced Mar 14, 2019
Member
Author
|
Please review and merge |
memsharded
requested changes
Mar 26, 2019
memsharded
approved these changes
Mar 26, 2019
memsharded
requested changes
Mar 27, 2019
| t.run("inspect {} -a description".format(reference2)) | ||
| self.assertIn("description: None", t.out) # The alias conanfile doesn't have description | ||
|
|
||
| def alias_short_paths_test(self): |
Member
There was a problem hiding this comment.
This test doesn't belong here. It also has a print to be removed.
| endif() | ||
| endmacro() | ||
|
|
||
| macro(conan_flags_setup) |
Member
There was a problem hiding this comment.
Is there any harm in leaving this macro? Even if not documented, some users might be using it, is it really necessary to remove it now?
Member
Author
There was a problem hiding this comment.
I think it is a very old macro no one should be using, but yes, I can keep it
This reverts commit ce82eb8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Use the same interface in
conan_basic_setup()for thecmake_multigeneratorDocs: conan-io/docs#1121
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.