Print an error in both Py2 and Py3 when no params are entered for commands with subarguments - #4902
Merged
Merged
Conversation
|
|
memsharded
reviewed
Apr 4, 2019
memsharded
left a comment
Member
There was a problem hiding this comment.
It would be nice to have a test for this behavior, and guarantee it doesn't break in the future.
Contributor
|
Please, merge |
Member
|
Good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Adding
subparsers.required = Truemakes both Py2 and Py3 print an error when no arguments are entered in commands that have subargumentsDocs: omit
Fixes #4816
Bug in python: https://bugs.python.org/issue9253#msg186387
developbranch, documenting this one.