Skip to content

Update check_compiler_version macro to handle latest Visual Studios - #5041

Merged
memsharded merged 3 commits into
conan-io:developfrom
jmarrec:hotfix/msvc
Apr 29, 2019
Merged

Update check_compiler_version macro to handle latest Visual Studios#5041
memsharded merged 3 commits into
conan-io:developfrom
jmarrec:hotfix/msvc

Conversation

@jmarrec

@jmarrec jmarrec commented Apr 26, 2019 •
edited by lasote
Loading

Copy link
Copy Markdown
Contributor

Changelog: Fix: A simple addition to ensure right compiler version is found on windows.
Docs: omit

(I have read the contributing guide. It's such a small thing that I didn't bother to create an issue first for this though).

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code: N/A
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one: N/A

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@CLAassistant

CLAassistant commented Apr 26, 2019 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@memsharded

memsharded commented Apr 28, 2019

Copy link
Copy Markdown
Member

Hi @jmarrec

Thanks for trying to contribute this PR.
The tests are broken, you can see the output of CI here: https://conan-ci.jfrog.info/blue/organizations/jenkins/ConanTestSuite/detail/PR-5041/1/pipeline. You can also try to run the tests locally with nosetests.

The problem is that you are using lexicographic string compare with STRLESS and you probably need to use numerical or version comparison in order to achieve the expected result. Please have a look at it, thanks!

@jmarrec

jmarrec commented Apr 28, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi, yeah I did see the failures earlier. Will look when back at a computer. What's the earliest cmake you intend to support? (Some functions aren't available in older cmake versions (eg strless_equal, not that I intend to use this one in particular)).I see some doc examples with 2.8, is that so?

@memsharded

memsharded commented Apr 28, 2019

Copy link
Copy Markdown
Member

Hi.
Yes, we are still trying to support CMake down to 2.8.12. This might change in the future, but so far, we are maintaining ourselves a few hacks to be compatible. Unfortunately there are still some users that can't upgrade cmake from that version easily.

@lasote lasote added this to the 1.15 milestone Apr 29, 2019
@memsharded

memsharded commented Apr 29, 2019

Copy link
Copy Markdown
Member

Great, thanks for the contribution

@memsharded
memsharded merged commit 6d3282f into conan-io:develop Apr 29, 2019
@jmarrec
jmarrec deleted the hotfix/msvc branch April 29, 2019 16:54
@danimtb danimtb mentioned this pull request Jul 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@memsharded memsharded

Labels

None yet

Projects

None yet

Milestone

1.15

Development

Successfully merging this pull request may close these issues.

4 participants

@jmarrec @CLAassistant @memsharded @lasote