Inherit scm from superclass - #5185
Merged
Merged
Conversation
jgsogo
suggested changes
May 20, 2019
|
|
||
| if len(to_replace) == 0: | ||
| # SCM exists, but not found in the conanfile, probably inherited from superclass | ||
| return |
Contributor
There was a problem hiding this comment.
Here we need to actually add the scm_data to this conanfile.py file. There is nothing to replace, but we need to add the dictionary to the class.
jgsogo
reviewed
May 20, 2019
jgsogo
left a comment
Contributor
There was a problem hiding this comment.
Have a look at the comments, but it is looking good 👍
Contributor
Author
|
Thanks for the quick reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Using
scmdeclared in a superclass failed exporting the recipe with the errorERROR: The conanfile.py defines more than one class level 'scm' attribute.Docs: omit
Closes #5181