Skip to content

Accept a list for the requires attribute - #5371

Merged
danimtb merged 2 commits into
conan-io:developfrom
jgsogo:issue/5313-requires-list
Jun 19, 2019
Merged

danimtb merged 2 commits into
conan-io:developfrom
jgsogo:issue/5313-requires-list

Conversation

@jgsogo

@jgsogo jgsogo commented Jun 19, 2019

Copy link
Copy Markdown
Contributor

Changelog: Fix: Accept a list for the requires attribute
Docs: conan-io/docs#1332

closes #5313

Accept a list for the requires attribute, now any of these formats will get the same result:

  • requires = "req/1.0@user/version", "req2/1.0@user/version"
  • requires = ("req/1.0@user/version", "req2/1.0@user/version")
  • requires = ["req/1.0@user/version", "req2/1.0@user/version"]

And also, if you specify the visibility of the requires:

  • requires = (("req/1.0@user/version", "private"), )
  • requires = [("req/1.0@user/version", "private"), ]

@lasote lasote left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An integration test is needed. You can probably modify the requirements from an existing one to be a list.

@lasote lasote added this to the 1.17 milestone Jun 19, 2019
@jgsogo

jgsogo commented Jun 19, 2019

Copy link
Copy Markdown
Contributor Author

I've just changed two random ones

@danimtb
danimtb merged commit 4a2e7fb into conan-io:develop Jun 19, 2019
@jgsogo
jgsogo deleted the issue/5313-requires-list branch June 19, 2019 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

requires attribute could accept a list in addition to a tuple

3 participants