Fix verify_ssl field in SCM discarded when used with False value - #5441
Merged
Merged
Conversation
lasote
reviewed
Jul 3, 2019
memsharded
requested changes
Jul 4, 2019
memsharded
reviewed
Jul 5, 2019
| "password": self.password, "type": self.type, "verify_ssl": self.verify_ssl, | ||
| "subfolder": self.subfolder, "submodule": self.submodule} | ||
| d = {k: v for k, v in d.items() if v} | ||
| d = {k: v for k, v in d.items() if v is not None and v is not ""} |
Member
There was a problem hiding this comment.
I am still not sure about removing empty strings. If someone defines an empty string, it will be removed from the dict, and it will become None. What tests were failing? Maybe the tests need to be fixed?
memsharded
pushed a commit
to memsharded/conan
that referenced
this pull request
Jul 8, 2019
…an-io#5441) * Fix verify_ssl field in SCM discarded when used with False value * Added comment * leave only None check * Also discard empty strings to avoid breaking tests
lasote
pushed a commit
that referenced
this pull request
Jul 8, 2019
* lockfiles * changed representation of lockfiles including the require->id * enabling test_package, without lock of python_requires (not in the graph-lock) * more tests, minor fixes * new test with package_revision_mode * --lockfile command line help * Fix verify_ssl field in SCM discarded when used with False value (#5441) * Fix verify_ssl field in SCM discarded when used with False value * Added comment * leave only None check * Also discard empty strings to avoid breaking tests * new test diamond lock
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix:
verify_sslfield in SCM being discarded when used withFalsevalue.Docs: omit
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.