Skip to content

[ci] Python 3.8 - #6355

Merged
jgsogo merged 6 commits into
conan-io:developfrom
jgsogo:py38/fix_tests
Jan 16, 2020
Merged

jgsogo merged 6 commits into
conan-io:developfrom
jgsogo:py38/fix_tests

Conversation

@jgsogo

@jgsogo jgsogo commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

Changelog: Bugfix: Fix broken compression of .tgz files due to Python 3.8 changing tar default schema.
Changelog: Fix: Recipe substitution for scm (old behavior) fixed for multiline comments in Python 3.8.
Docs: conan-io/docs#1526

#PYVERS: py38
#tags: slow, svn
#revisions: 1

@jgsogo jgsogo changed the title [wip][ci] Python 3.8 [ci] Python 3.8 Jan 15, 2020
@jgsogo jgsogo added this to the 1.22 milestone Jan 15, 2020
@jgsogo jgsogo self-assigned this Jan 15, 2020
@jgsogo

jgsogo commented Jan 16, 2020

Copy link
Copy Markdown
Contributor Author

This is running py38 for all the platforms and many Python versions (py38, py36, py27) and with/out revisions. It also includes your changes from #6348.

I think it is what we need to say "Conan support py38" (we need to run the preflight and full test suite, but we are close enough)

@jgsogo
jgsogo requested a review from memsharded January 16, 2020 09:01
@jgsogo jgsogo assigned danimtb and unassigned jgsogo Jan 16, 2020

@memsharded memsharded left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take the changelog (or similar) from my PR, and then my PR can be closed.

@jgsogo
jgsogo merged commit 6d57495 into conan-io:develop Jan 16, 2020
@jgsogo
jgsogo deleted the py38/fix_tests branch January 16, 2020 12:40
jgsogo added a commit to jgsogo/conan that referenced this pull request Jan 29, 2020
* fixing some broken tests for python 3.8

* fix test for AST replacement

* fixing missing error msg in server

Co-authored-by: James <james@conan.io>
jgsogo added a commit that referenced this pull request Jan 30, 2020
* [ci] Python 3.8 (#6355)

* fixing some broken tests for python 3.8

* fix test for AST replacement

* fixing missing error msg in server

Co-authored-by: James <james@conan.io>

* py38 different bufsize default

* improving data test (#6341)

Co-authored-by: James <james@conan.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants