[fix] Use 'profile_build' (if given) to create graph for the test_package functionality - #7182
Merged
Merged
Conversation
jgsogo
marked this pull request as draft
June 10, 2020 15:25
jgsogo
commented
Jun 10, 2020
jgsogo
left a comment
Contributor
Author
There was a problem hiding this comment.
Still some doubts I need to test
memsharded
approved these changes
Jun 29, 2020
memsharded
left a comment
Member
There was a problem hiding this comment.
I'd say this is already good as-is, despite other possible fixes or other open issues
jgsogo
marked this pull request as ready for review
June 29, 2020 14:50
Contributor
Author
|
I've removed the TODOs and refactor the new tests to avoid duplicated code. I also think it is good as it is. |
memsharded
approved these changes
Jun 30, 2020
danimtb
approved these changes
Jun 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Graph created for the
test_package/conanfile.pyrecipe takes theprofile:buildif given.Docs: omit
Related to some comments in #7132 (comment)
The
test_packagefunctionality was not taking into account theprofile:buildso thetools.cross_buildingtool was not able to identify context properly... andbuild_requiresin the test_package recipe didn't assign to the proper context.