Skip to content

Bringing back build colourisation - #7740

Merged
memsharded merged 8 commits into
conan-io:developfrom
czoido:fix/5597
Sep 23, 2020
Merged

memsharded merged 8 commits into
conan-io:developfrom
czoido:fix/5597

Conversation

@czoido

@czoido czoido commented Sep 22, 2020

Copy link
Copy Markdown
Contributor

Changelog: Fix: Do not capture output for normal conan run (no logging or testing) when launching processes via ConanRunner so that color from build tools output is not lost.
Docs: omit

This is a proposal for recovering ConanRunner colorisation. Maybe we just want to capture the stdout using Popen and therefore disabling color codes when we are running the tests (the stream will be a StringIO) or when we explicitly set run_to_file=True or run_to_output=False.

Closes: #5597

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@czoido czoido closed this Sep 22, 2020
@czoido czoido reopened this Sep 22, 2020
@czoido czoido closed this Sep 22, 2020
@czoido czoido reopened this Sep 22, 2020
@czoido czoido closed this Sep 23, 2020
@czoido czoido reopened this Sep 23, 2020
@czoido
czoido marked this pull request as ready for review September 23, 2020 13:21
@czoido czoido added this to the 1.30 milestone Sep 23, 2020
@czoido
czoido requested a review from memsharded September 23, 2020 13:22
@memsharded
memsharded merged commit 558a2ce into conan-io:develop Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toolchain Build Colourisation Lost

2 participants