Remove cryptography, pyopenssl and idna from requirements - #8075
Merged
memsharded merged 1 commit intoNov 18, 2020
Merged
Conversation
memsharded
approved these changes
Nov 18, 2020
This was referenced Nov 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Remove cryptography, pyopenssl and idna from OSX requirements in Python.
Docs: omit
Closes: #8061
Close: #7286
As summarised in this comment, looks like it would be safe to remove these 3 Python dependencies:
idnawas introduced because installing via requests was installing an incorrect version but looks like the issue is not happening any more so it should be safe to remove.pyopensslandcryptographywere introduced just for OSX here: memsharded/conan@10d69ff because of Downloads from certain SSL domains fails in OSX #309The only cases that might fail is for Python<2.7.9 and a very old openssl version in the host platform. In that case this could be solved by doing python -m pip install pyopenssl cryptography idna so it looks relatively safe to remove this dependencies.
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.
#TAGS: svn, slow
#REVISIONS: 1