if the build_require not activated shouldn't fail - #9046
Merged
memsharded merged 2 commits intoJun 3, 2021
Merged
memsharded merged 2 commits into
memsharded merged 2 commits into
Conversation
lasote
reviewed
Jun 3, 2021
| build_req = self._conanfile.dependencies.build_requires_build_context | ||
|
|
||
| # Check if the same package is at host and build and the same time | ||
| common = {r.ref.name for r in host_req}.intersection({r.ref.name for r in build_req}) |
Contributor
There was a problem hiding this comment.
I think it would be more readable and short just filtering the activated, something like:
activated_br = {r.ref.name for r in build_req if r.ref.name in self.build_context_activated}
common_names = {r.ref.name for r in host_req}.intersection(activated_br)
Member
Author
There was a problem hiding this comment.
Changed, please review.
In any case, the important feedback here is if this makes sense as default behavior, or I am missing some other thing.
Contributor
There was a problem hiding this comment.
This check? Yes, it was missing and makes perfect sense.
lasote
approved these changes
Jun 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Do not fail in
CMakeDepswhen there arebuild_requireswith same name as host requires, unlessbuild_context_activatedis enabled for those and a different suffix has not been defined.Docs: Omit