Fixed CMake toolchain for M1 crossbuilding and moved/completed test - #9011
Merged
memsharded merged 4 commits intoMay 27, 2021
Merged
Conversation
memsharded
approved these changes
May 27, 2021
memsharded
approved these changes
May 27, 2021
| cmakelists = textwrap.dedent(""" | ||
| cmake_minimum_required(VERSION 3.15) | ||
| project(MyApp CXX) | ||
| set(hello_DIR "${CMAKE_BINARY_DIR}") |
Member
There was a problem hiding this comment.
Hopefully this hello_DIR should no longer be necessary?
Contributor
Author
There was a problem hiding this comment.
Yes, it is yet necessary to trick CMake (when cross-building on Apple) to search outside the system frameworks dirs.
Member
There was a problem hiding this comment.
Ok, lets merge this, and address that in a separate issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: The
CMakeToolchainnow supports Apple M1 cross-building with a profile without environment declared pointing to the system toolchain.Docs: omit
Moved test (was not testing frameworks) and refactored to test iOS armv8 and Macos armv8 without any trick in the profile.