Skip to content

Fix Bazel build string defines - #9139

Merged
tapia merged 1 commit into
conan-io:developfrom
fanStefan:feature/fix_bazel_string_defines
Jun 23, 2021
Merged

tapia merged 1 commit into
conan-io:developfrom
fanStefan:feature/fix_bazel_string_defines

Conversation

@fanStefan

@fanStefan fanStefan commented Jun 22, 2021

Copy link
Copy Markdown
Contributor

Changelog: Fix: Fix Bazel build string defines.
Docs: omit

Closes: #9138

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@CLAassistant

CLAassistant commented Jun 22, 2021

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@memsharded memsharded added this to the 1.38 milestone Jun 22, 2021
@tapia

tapia commented Jun 23, 2021

Copy link
Copy Markdown
Contributor

Thanks @fanStefan for the fix! We really appreciate the feedback on the new bazel support.

@tapia
tapia merged commit d3ca0f1 into conan-io:develop Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Bazel issue when using string value for defines

4 participants