meson 0.60 broke preprocessor defs - #9858
Merged
memsharded merged 1 commit intoOct 24, 2021
Merged
Conversation
memsharded
commented
Oct 24, 2021
memsharded
left a comment
Member
Author
There was a problem hiding this comment.
I am going to merge this, as both "develop" and "develop2" and all PRs to both are currently broken, and this fixes it. Note the fix works also in <0.60 like 0.59 which seems to still be installed in Linux agents (0.60 seems to have been updated in Win and OSX). Please review anyway, just in case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Change
MesonToolchainto definepreprocessor_definitionsas[constant], because Meson 0.60 now raises errors on it defined in[built-in options].Docs: Omit