qcbor: add version 1.2 - #15400
qcbor: add version 1.2#15400
Conversation
| options = { | ||
| "shared": [True, False], | ||
| "fPIC": [True, False], | ||
| "disable_float": [False, "HW_USE", "PREFERRED", "ALL"], |
There was a problem hiding this comment.
Options should be lowercase 🤔 I dont recall if that meant values too
There was a problem hiding this comment.
It should be applied to values too, because on case-sensitive systems like Linux, it will be affected. We didn't enforce it because fPIC is an exception (I would prefer using fpic on Conan 2.0 but it would affect all recipes ...)
| tc.variables["QCBOR_OPT_DISABLE_FLOAT_HW_USE"] = self.options.disable_float in ["HW_USE", "PREFERRED", "ALL"] | ||
| tc.variables["QCBOR_OPT_DISABLE_FLOAT_PREFERRED"] = self.options.disable_float in ["PREFERRED", "ALL"] | ||
| tc.variables["QCBOR_OPT_DISABLE_FLOAT_ALL"] = self.options.disable_float == "ALL" | ||
| tc.cache_variables["CMAKE_POLICY_DEFAULT_CMP0077"] = "NEW" |
There was a problem hiding this comment.
this should be fixed in 1.54
There was a problem hiding this comment.
@toge currently we are running Conan 1.57.0 here in CCI: https://github.com/conan-io/conan-center-index/blob/master/.c3i/config_v1.yml#L6 so you could update required_conan_version to 1.54.0 and remove CMAKE_POLICY_DEFAULT_CMP0077 line
uilianries
left a comment
There was a problem hiding this comment.
It's good enough, can be improved in another PR.
* qcbor: add version 1.2 * revert disable_float option
Specify library name and version: qcbor/*