Skip to content

- [zlib] there are no frameworks - #11139

Closed
SSE4 wants to merge 1 commit into
conan-io:masterfrom
SSE4:zlib_no_frameworks
Closed

- [zlib] there are no frameworks#11139
SSE4 wants to merge 1 commit into
conan-io:masterfrom
SSE4:zlib_no_frameworks

Conversation

@SSE4

@SSE4 SSE4 commented Jun 12, 2022

Copy link
Copy Markdown
Contributor

Specify library name and version: zlib/all

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@SSE4
- [zlib] there is no frameworks
c027fcc 
Signed-off-by: SSE4 <tomskside@gmail.com>
@ghost ghost mentioned this pull request Jun 12, 2022
Closed
@ghost

ghost commented Jun 12, 2022 •
edited by ghost
Loading

Copy link
Copy Markdown

I detected other pull requests that are modifying zlib/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

Sign in to view
@AndreyMlashkin

AndreyMlashkin commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

Why is this change needed at all?

@ghost ghost mentioned this pull request Jun 13, 2022
Closed
4 tasks
@SSE4

SSE4 commented Jun 13, 2022

Copy link
Copy Markdown
Contributor Author

Why is this change needed at all?

V2 no longer removes non-existing directories from cpp_info. same for all new build helpers and generators, like AutotoolsDeps and PkgConfigDeps.
as a result, builds fail: #11053 (comment)
maybe @czoido or @franramirez688 may comment on this, as it will require a fix in every recipe.

@franramirez688 franramirez688 mentioned this pull request Jun 13, 2022
Closed
@conan-center-bot

conan-center-bot commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

All green in build 2 (c027fcc105542846faeb6274c00add6313011d61):

  • zlib/1.2.12@:
    All packages built successfully! (All logs)

  • zlib/1.2.11@:
    All packages built successfully! (All logs)

@madebr

madebr commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

Making this change to every recipe, including every module will be painful.

@franramirez688

franramirez688 commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

@SSE4 @madebr @AndreyMlashkin

Finally, it has been implemented by conan-io/conan#11455 so it will not be necessary to change all the recipes. It'll be released in the next Conan 1.50.

@SSE4 SSE4 closed this Jun 15, 2022
@SSE4 SSE4 mentioned this pull request Aug 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@madebr madebr madebr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SSE4 @conan-center-bot @AndreyMlashkin @madebr @franramirez688