Skip to content

Update logging level names - #1419

Merged
lasote merged 3 commits into
conan-io:developfrom
uilianries:feature/logging-names
Dec 5, 2019
Merged

lasote merged 3 commits into
conan-io:developfrom
uilianries:feature/logging-names

Conversation

@uilianries

Copy link
Copy Markdown
Member

Related PR: conan-io/conan#5772

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@Minimonium

Copy link
Copy Markdown
Contributor

It'd be cool to have some examples of what we can expect to get from these log levels.

@jgsogo

jgsogo commented Nov 6, 2019

Copy link
Copy Markdown
Contributor

Yes, @Minimonium , it would be nice, but I think that the two files modified in this PR (up to now) aren't the place to add this information... those are sections inside already long files.

I would suggest improving the Logging one (https://docs.conan.io/en/latest/mastering/logging.html): there we talk about CONAN_TRACE_FILE but we say nothing about the logging level and it would probably make a lot of sense, wdyt @danimtb ?

@danimtb

danimtb commented Nov 6, 2019

Copy link
Copy Markdown
Member

Yes, makes sense to have that in the logging one

@jgsogo jgsogo added this to the 1.21 milestone Nov 7, 2019
@uilianries

Copy link
Copy Markdown
Member Author

Yes, @Minimonium , it would be nice, but I think that the two files modified in this PR (up to now) aren't the place to add this information... those are sections inside already long files.

I gonna open a new issue to introduce those examples.

@lasote
lasote merged commit 1cfdaae into conan-io:develop Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants