Skip to content

- update docs for MesonToolchain and Meson (build helper) - #1980

Merged
memsharded merged 6 commits into
conan-io:developfrom
SSE4:meson_build_helper
Jan 19, 2021
Merged

- update docs for MesonToolchain and Meson (build helper)#1980
memsharded merged 6 commits into
conan-io:developfrom
SSE4:meson_build_helper

Conversation

@SSE4

@SSE4 SSE4 commented Jan 12, 2021

Copy link
Copy Markdown
Contributor

@SSE4
SSE4 requested a review from czoido January 12, 2021 17:48
This was referenced Jan 12, 2021
Merged
Merged
czoido
czoido reviewed Jan 12, 2021
View reviewed changes
Comment thread creating_packages/toolchains/meson.rst
@czoido czoido added this to the 1.33 milestone Jan 12, 2021
danimtb
danimtb reviewed Jan 19, 2021
View reviewed changes
Comment thread creating_packages/toolchains/meson.rst Outdated
Comment thread creating_packages/toolchains/meson.rst Outdated
Comment thread creating_packages/toolchains/meson.rst Outdated
memsharded
memsharded requested changes Jan 19, 2021
View reviewed changes

@memsharded memsharded left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All new toolchains and helpers are documented in reference -> conanfile -> tools, as conan.tools.meson in this case.

@SSE4

SSE4 commented Jan 19, 2021

Copy link
Copy Markdown
Contributor Author

All new toolchains and helpers are documented in reference -> conanfile -> tools, as conan.tools.meson in this case.

as I can see MakeToolchain, MSBuildToolchain, CMakeToolchain are documented in creating packages -> toolchain

@memsharded

memsharded commented Jan 19, 2021

Copy link
Copy Markdown
Member

as I can see MakeToolchain, MSBuildToolchain, CMakeToolchain are documented in creating packages -> toolchain

@SSE4

Those were there before creating the new conan.tools.xxx spaces. They are gradually being moved from there to the reference. Please move the Meson one there as well.

SSE4 added 2 commits January 19, 2021 19:34
@SSE4
- update docs for MesonToolchain and Meson (build helper)
419edc1 
Signed-off-by: SSE4 <tomskside@gmail.com>
@SSE4
- move
0180f9d 
Signed-off-by: SSE4 <tomskside@gmail.com>
@SSE4
SSE4 force-pushed the meson_build_helper branch from 3df5f6f to 0180f9d Compare January 19, 2021 12:40
@danimtb

danimtb commented Jan 19, 2021

Copy link
Copy Markdown
Member

@SSE4 my comments/suggestion were not addressed as the file changed location, please go through them and update the file in the new location

SSE4
SSE4 commented Jan 19, 2021
View reviewed changes
Comment thread reference/conanfile/tools/meson.rst Outdated
SSE4
SSE4 commented Jan 19, 2021
View reviewed changes
Comment thread reference/conanfile/tools/meson.rst Outdated
SSE4
SSE4 commented Jan 19, 2021
View reviewed changes
Comment thread reference/conanfile/tools/meson.rst Outdated
memsharded
memsharded approved these changes Jan 19, 2021
View reviewed changes

@memsharded memsharded left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the import and can be merged

Comment thread reference/conanfile/tools/meson.rst Outdated
SSE4
SSE4 commented Jan 19, 2021
View reviewed changes
Comment thread reference/conanfile/tools/meson.rst Outdated
@memsharded
memsharded merged commit d841e03 into conan-io:develop Jan 19, 2021
@dependabot dependabot Bot mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@czoido czoido czoido approved these changes
@danimtb danimtb danimtb left review comments
@memsharded memsharded memsharded approved these changes

Assignees

@czoido czoido

Labels

None yet

Projects

None yet

Milestone

1.33

Development

Successfully merging this pull request may close these issues.

[bug] documentation wrong conan_meson_native.ini should be conan_meson_cross.ini

4 participants

@SSE4 @memsharded @danimtb @czoido