Added PkgConfigDeps generator - #2133
Merged
Merged
Conversation
franramirez688
commented
Jun 25, 2021
franramirez688
force-pushed
the
feature/pkg_config_deps
branch
from
June 25, 2021 12:29
cfae6b5 to
437579a
Compare
5 tasks
czoido
reviewed
Jun 29, 2021
czoido
reviewed
Jun 29, 2021
czoido
approved these changes
Jun 29, 2021
memsharded
approved these changes
Jun 29, 2021
memsharded
left a comment
Member
There was a problem hiding this comment.
Good enough to be merged for the release, but a couple of notes to take into account (can be addressed later)
| Components | ||
| ++++++++++ | ||
|
|
||
| If a recipe uses :ref:`components<package_information_components>`, the files generated will be *<COMP-NAME>.pc* with their corresponding |
Member
There was a problem hiding this comment.
Isn't the name PKG-NAME_COMP-NAME.pc? I think it could be better this way, to avoid potential conflicts with components of different packages. Or is not possible?
Contributor
Author
There was a problem hiding this comment.
The thing is that I got this doc-lines about the Components from this one https://docs.conan.io/en/latest/reference/generators/pkg_config.html Anyway, I'm gonna check it 😉
lasote
approved these changes
Jun 30, 2021
lasote
left a comment
Contributor
There was a problem hiding this comment.
Probably we want to change the pc file names when components using the @memsharded suggestion for the next release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added documentation related to new conan/feature: conan-io/conan#9152
Added new
PkgConfigDepsgenerator inconan.tools.gnu.pkgconfigdeps.py