Clarify CMakeToolchain User presets documentation - #2591
Merged
lasote merged 1 commit intoJun 16, 2022
Merged
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the documentation was correct before (and conan-io/conan#11452 simply fixes the bug where it was not following the documentation).
This PR just tries to clarify the behaviour of that file, a separate more elaborate note about how it will not be generated, and some general fixes for grammar consistency.
I've removed the mention to
conanfile.generators_folderfrom that particular section, but I think that attribute affects the other files generated as well, so I felt it was odd only mentioning there. Will raise a separate PR to document it in the conanfile reference.