Repository navigation
fix removing Committed - #24
Merged
Merged
Conversation
when removing Committed, the ZFS dataset `foopool/foofs/42@snapshot` was removed but `foopool/foofs/42` was not removed. Fix containerd#22 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Member
Author
|
LGTM. Thanks for taking a look! |
mattikus
approved these changes
Aug 23, 2019
mattikus
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this. Some small comments.
AkihiroSuda
force-pushed
the
fix-remove-committed
branch
from
August 23, 2019 18:57
a20a4a7 to
6fde16e
Compare
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
- Coverage 57.71% 55.68% -2.04%
==========================================
Files 1 1
Lines 175 176 +1
==========================================
- Hits 101 98 -3
- Misses 49 51 +2
- Partials 25 27 +2
Continue to review full report at Codecov.
|
Member
Author
|
@fuweid PTAL? |
Member
|
ping @AkihiroSuda sorry for the late reply. done |
Member
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when removing Committed, the ZFS dataset
foopool/foofs/42@snapshotwasremoved but
foopool/foofs/42was not removed.Fix #22