Fix parent component inspection - #50
Merged
Merged
Conversation
jadefish
force-pushed
the
b/fix-parent-component-inspection
branch
from
December 1, 2023 18:56
bd5d772 to
5434398
Compare
jadefish
force-pushed
the
b/fix-parent-component-inspection
branch
2 times, most recently
from
December 5, 2023 19:28
9b0477e to
ed114dd
Compare
dsgraham
approved these changes
Dec 6, 2023
The web client's API application loses POM hierarchy when inflating JSON to POM. This causes components which rely on checking their parent (or an ancestor) for an attribute to exhibit different behavior and render differently than the web client's view-rendering (non-API) application. This change allows templates to pass down local variables (as one expects to do with ERB), and updates the places relying on the above behavior to use locals instead.
Also stop running semantic release for PRs.
jadefish
force-pushed
the
b/fix-parent-component-inspection
branch
from
December 8, 2023 13:47
ed114dd to
f97127e
Compare
DSL components inflated from JSON can end up with strings instead of symbols for attribute values. This change coerces icon positions to strings to standardize comparison of icon positions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(web_client): Fix ERB inspection of parents
The web client's API application loses POM hierarchy when inflating JSON to POM. This causes components which rely on checking their parent (or an ancestor) for an attribute to exhibit different behavior and render differently than the web client's view-rendering (non-API) application.
This change allows templates to pass down local variables (as one expects to do with ERB), and updates the places relying on the above behavior to use locals instead.
Miscellaneous