fix: Use route options when building URLs - #51
Merged
Conversation
rhetprieto
approved these changes
Dec 5, 2023
rhetprieto
left a comment
Contributor
There was a problem hiding this comment.
Looks good, IMO we don't need to keep the old behavior
Contributor
Author
yeah, agreed. it's a breaking change, but it's going into beta, which is full of those... and the old behavior is confusing. I'll update to only keep the new behavior. |
jadefish
force-pushed
the
b/fix-rails-route-helper
branch
2 times, most recently
from
December 8, 2023 13:59
b0cba21 to
0908f14
Compare
When Rails is present, COPRL should use the Rails route URL options to construct URLs instead of ActionController URL options. BREAKING CHANGE: `action_controller.default_url_options` is no longer examined to determine how COPRL should build URLs. If your application relies on this behavior, migrate to `routes.default_url_options` before upgrading COPRL.
jadefish
force-pushed
the
b/fix-rails-route-helper
branch
from
December 8, 2023 14:01
0908f14 to
c624409
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Rails is present, COPRL should use the Rails route URL options to construct URLs instead of ActionController URL options.
BREAKING CHANGE:
action_controller.default_url_optionsis no longer examined to determine how COPRL should build URLs. If your application relies on this behavior, migrate toroutes.default_url_optionsbefore upgrading COPRL.