Change Roboto to system-ui - #68
Merged
Merged
Conversation
jadefish
reviewed
Jan 2, 2024
jadefish
left a comment
Contributor
There was a problem hiding this comment.
This is a huge diff for a small change – did something with bundle generation change?
Collaborator
Author
|
@jadefish Yeah, it looks like the way the output CSS is formatted has changed. This should probably be rolled into the SCSS build PR. |
added 3 commits
January 2, 2024 14:39
This means that we're no longer loading a web font as the default font. This reduces remote dependencies and overall bandwidth of a page.
danbee
force-pushed
the
use-system-ui-instead-of-roboto
branch
from
January 2, 2024 20:40
6fefa47 to
5dfd7a0
Compare
jadefish
reviewed
Jan 2, 2024
jadefish
approved these changes
Jan 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means that we're no longer loading a web font as the default font. This reduces remote dependencies and overall bandwidth of a page.
Different platforms will get slightly different fonts, with iOS and macOS getting San Francisco, Windows getting Segue UI, and Android getting Roboto. These fonts fit the platforms better and have similar metrics and appearance to Roboto.
This also means that if a site loads a custom font, they're only loading the custom font and not Roboto as well.