Fix error display for "nested" form data - #79
Merged
Conversation
jadefish
force-pushed
the
b/fix-nested-errors
branch
from
February 12, 2024 15:07
caba216 to
9955df0
Compare
This change fixes the web client's error handling to properly interpret and display errors for nested field names (e.g. `address[ln1]`) next to the form field itself.
An error group element allows users to provide a closer target for errors that would otherwise be rendered at the top of the page. If a validation error refers to a nested field (e.g. `address[ln1]`), and an `data-error-group="address"` element is on the page, any messages for address fields will instead be rendered within the error group element. This logic applies only to page-level error message display. If a form field for an error message is accessible, an error group matching the message (if present) is not used.
jadefish
force-pushed
the
b/fix-nested-errors
branch
from
February 12, 2024 17:46
9955df0 to
37dce82
Compare
jadefish
marked this pull request as ready for review
February 12, 2024 17:49
dsgraham
approved these changes
Feb 16, 2024
jadefish
force-pushed
the
b/fix-nested-errors
branch
from
February 22, 2024 16:58
37dce82 to
062c565
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle nested field names in VErrors
This change fixes the web client's error handling to properly interpret and display errors for nested field names (e.g.
address[ln1]) next to the form field itself.Miscellaneous