Skip to content

Remove Coprl::Trace - #99

Open
jadefish wants to merge 4 commits into
mainfrom
b/stop-patching-object
Open

jadefish wants to merge 4 commits into
mainfrom
b/stop-patching-object

Conversation

@jadefish

@jadefish jadefish commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Coprl::Trace was included globally (I think accidentally) in the Pluggable module, which meant it was mixed into Object (yes, EVERY object).

"meow".send(:logger).warn("hello")
# W, [2026-10-07T22:29:02.011274 #40426]  WARN -- : hello
#=> true

4.send(:logger).fatal("astounding")
# F, [2026-10-07T22:30:33.482862 #40426] FATAL -- : astounding
#=> true

send(:logger).info("oh my")
# I, [2026-10-07T22:31:08.078595 #40426]  INFO -- : oh my
#=> true

A bunch of call sites implicitly relied on this fact. Rather than find and fix them all in the world's worst game of cat-and-mouse, the Trace module has been removed entirely.

Miscellaneous

Fixes for some existing issues to get the RSpec suite passing again.

  • Fix args in clipboard plugin demo (Ruby 3)
  • Fix header double render in test
  • Pass through header title argument

@jadefish
jadefish requested a review from a team October 8, 2026 02:31
@jadefish
jadefish marked this pull request as draft October 8, 2026 13:08
@jadefish
jadefish force-pushed the b/stop-patching-object branch from 62c7c1d to 81e3ff5 Compare October 8, 2026 13:36
Coprl::Trace was included globally (I think accidentally) in the
Pluggable module, which meant it was mixed into Object (yes, EVERY
object). A bunch of call sites implicitly relied on this fact.

Rather than find and fix them all in the world's worst game of
cat-and-mouse, the Trace module has been removed entirely.
Header needs to just return itself if it's already been rendered
(#locked?), like other components do.
@jadefish
jadefish force-pushed the b/stop-patching-object branch from 81e3ff5 to 09af236 Compare October 8, 2026 13:36
@jadefish jadefish changed the title Remove top-level Coprl::Trace include Remove Coprl::Trace Oct 8, 2026
@jadefish
jadefish changed the base branch from main to reinitialize-coprl-after-turbo-visit October 8, 2026 13:37
@jadefish
jadefish marked this pull request as ready for review October 8, 2026 13:40
Base automatically changed from reinitialize-coprl-after-turbo-visit to main October 8, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants