Repository navigation
Conversation
jadefish
marked this pull request as draft
October 8, 2026 13:08
jadefish
force-pushed
the
b/stop-patching-object
branch
from
October 8, 2026 13:36
62c7c1d to
81e3ff5
Compare
Coprl::Trace was included globally (I think accidentally) in the Pluggable module, which meant it was mixed into Object (yes, EVERY object). A bunch of call sites implicitly relied on this fact. Rather than find and fix them all in the world's worst game of cat-and-mouse, the Trace module has been removed entirely.
Header needs to just return itself if it's already been rendered (#locked?), like other components do.
jadefish
force-pushed
the
b/stop-patching-object
branch
from
October 8, 2026 13:36
81e3ff5 to
09af236
Compare
jadefish
changed the base branch from
main
to
reinitialize-coprl-after-turbo-visit
October 8, 2026 13:37
jadefish
marked this pull request as ready for review
October 8, 2026 13:40
rhetprieto
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coprl::Tracewas included globally (I think accidentally) in thePluggablemodule, which meant it was mixed intoObject(yes, EVERY object).A bunch of call sites implicitly relied on this fact. Rather than find and fix them all in the world's worst game of cat-and-mouse, the Trace module has been removed entirely.
Miscellaneous
Fixes for some existing issues to get the RSpec suite passing again.