Do not access owner type in dispatch if it is not passed at runtime - #17424
Open
HertzDevil wants to merge 1 commit into
Open
HertzDevil wants to merge 1 commit into
HertzDevil wants to merge 1 commit into
Conversation
straight-shoota
approved these changes
Sep 16, 2026
ysbaddaden
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a call triggering method dispatch has no receiver, Crystal always generates code that accesses the current scope's type ID, even when that type is not passed as an argument at all, and therefore could not possibly affect method dispatch at runtime. Often those types are the top-level scope or a file-private scope:
The access manifests as unused loads of newly allocated type IDs for those scopes: (the environment variable
CRYSTAL_DUMP_TYPE_ID=1could also reveal those type IDs)These loads are strictly unnecessary, and more importantly, new type IDs should not be allocated at all during LLVM IR generation (more on this later). This PR ensures that the loads and type IDs are gone.