Repository navigation
W8: feat/working-tree-performance-finalization - #64
Merged
Merged
Conversation
aman-a-shah
approved these changes
Nov 8, 2026
aman-a-shah
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the status/diff changes, checkout protections, and regression coverage. Lint, formatting, and all 410 tests pass on the PR head. The performance report references an absent bench_working_tree.py; track reproducibility and shared-benchmark reruns in the final handoff work.
This was referenced Nov 8, 2026
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.path.relpathonce per file (6003getcwdcalls for 3000 files). It now works out each folder once, in one sharedwalk_working_files()used bystatus,diffand the name lists.statusanddifftake about 45% less time with many files. Results are identical; every file is still read and hashed, with no cache and no timestamp shortcuts.mainso M3's merge-resolve code incmd_addandcmd_statusis kept.docs/performance.md.Validation
scripts/quality-check.shChecklist
Notes for Reviewers