Skip to content

44 week 7 m1 finalize packfiles storage performance baseline - #65

Merged
aman-a-shah merged 4 commits into
mainfrom
44-week-7---m1-finalize-packfiles-storage-performance-baseline
Nov 8, 2026
Merged

aman-a-shah merged 4 commits into
mainfrom
44-week-7---m1-finalize-packfiles-storage-performance-baseline

Conversation

@mahis1067

Copy link
Copy Markdown
Collaborator

Summary

Created _parse_object_header in remote.py to parse an OBJ header
Fixing methods in RemoteServer
Fix validate pack method and decode pack record
Fix ObjectStore initializer
Create _read_cached_index
Create benchmark_packfiles.py to measure packing, reads and stores bytes

Tests made

  • Tests corrupt loose objects win over valid packed copy
  • Tests fresh store lookup modes preserve missing and corrupt distinction
  • Tests packed lookup validate every record before returning
  • Tests published pack and index version are validated
  • Test published pack count and index offset are validated
  • Fix test pack publication leaves previous object readable
  • Test pack publication failures cleans temporary files
  • Test packed index cache discovers new packs
  • Test packed index cache rechecks changes pack
  • Test fresh store reads multiple packs and objects

Validation

  • scripts/quality-check.sh
  • Manual testing, if applicable:

Checklist

  • The change is focused and easy to review.
  • Tests were added or updated for behavior changes.
  • Documentation was updated for user-facing or setup changes.
  • No secrets, generated artifacts, or local-only files are included.

Notes for Reviewers

Tests failed

  • test_ref_paths_reject_symlinks_and_file_directory_collisions
  • test_mode_only_change_is_modified_with_no_line_edits
  • test_cli_mode_only_change
  • test_fast_forward_into_fresh_repo_restores_everything
  • test_second_fast_forward_applies_edit_delete_new_dir_and_mode
  • test_bad_ref_session_does_not_stop_server
  • test_bad_ref_session_does_not_stop_server
  • test_bad_ref_session_does_not_stop_server

@mahis1067 mahis1067 linked an issue Oct 27, 2026 that may be closed by this pull request
5 tasks

@aman-a-shah aman-a-shah left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed pack validation, metadata caching, bounded transfer headers, and regression coverage. Original head passes lint, formatting, and all 402 tests locally on macOS; CI also passes after updating against main. Final measurement consolidation and cache assumptions remain explicit in #67 and #70.

@aman-a-shah
aman-a-shah merged commit bc3ed1e into main Nov 8, 2026
1 check passed
@aman-a-shah
aman-a-shah deleted the 44-week-7---m1-finalize-packfiles-storage-performance-baseline branch November 8, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Week 7 - M1: Finalize packfiles + storage performance baseline

2 participants