Repository navigation
Bound pack-index caching and verify replacement detection - #71
Merged
aman-a-shah merged 2 commits intoNov 18, 2026
Merged
aman-a-shah merged 2 commits into
aman-a-shah merged 2 commits into
Conversation
5 tasks
aman-a-shah
approved these changes
Nov 18, 2026
aman-a-shah
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the bounded cache, metadata invalidation, selected-record validation, and publication guarantees. Added regressions for replaced pack/index files retaining the original size and modification time. Lint, formatting, and all 445 tests pass locally, including the network integration tests. Reproduced the cached/uncached storage fixture sequentially and corrected the scope and revision claims in the performance documentation. Shared project/network measurements remain tracked in #47/#58.
aman-a-shah
deleted the
55-week-8---m1-measured-storage-optimizations-packfile-regression-checks
branch
November 18, 2026 15:24
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pack metadata now uses a 64-entry least-recently-used cache. The signature includes each pack/index file's size, modification time, and inode, so atomic replacement invalidates prior validation even when size and modification time are preserved. Selected records remain decoded and hash-checked on every read.
Adds eviction and replacement regressions, preserves source imports in CLI subprocess tests, and handles platform-specific executable-bit, filename, and symlink constraints in the existing tests. Packfile documentation states the cache's immutability assumptions and per-index memory limits.
The performance report includes commands, exact production revision, environment, fixture shape, and cached/uncached measurements. Earlier Windows observations are distinguished from the reproduced run. The 512-blob fixture does not complete the shared project/network benchmark.
Related to #55. Shared fixture and final integration acceptance remain tracked in #47 and #58; this PR does not close those prerequisites.
Validation
scripts/quality-check.sh: lint, formatting, and 445 tests pass on Python 3.13.5/macOS.scripts/benchmark_packfiles.py --profileand--no-cache --profile: sequential runs against production code atd00685dc1d853c22eb3bb744db23929b3d6fcecf, with commands/results indocs/performance.md.Checklist