Skip to content

Conversation

@Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Apr 22, 2024

template arguments is_signed is not passed.

template <class T, bool is_signed, bool round_to_next_byte = false>
static bitpacking_width_t FindMinimumBitWidth(T min_value, T max_value) {

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
Copy link
Contributor Author

@Mytherin PTAL~

@Mytherin Mytherin requested a review from samansmink April 22, 2024 05:49
@Mytherin Mytherin merged commit bc3cb2e into duckdb:main Apr 24, 2024
@Mytherin
Copy link
Collaborator

Thanks! LGTM

@Lloyd-Pottiger Lloyd-Pottiger deleted the fix-bitpacking branch April 24, 2024 08:04
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request May 5, 2024
Merge pull request duckdb/duckdb#11757 from Lloyd-Pottiger/fix-bitpacking
Merge pull request duckdb/duckdb#11801 from Tishj/python_sqllogic_test_fix2
Merge pull request duckdb/duckdb#11790 from jzavala-gonzalez/python-write-parquet-options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants