[PythonDev] Fix up failing tests in CI #11801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…broken but due to a bug in the C++ API it's silently ignored
Collaborator
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
May 5, 2024
Merge pull request duckdb/duckdb#11757 from Lloyd-Pottiger/fix-bitpacking Merge pull request duckdb/duckdb#11801 from Tishj/python_sqllogic_test_fix2 Merge pull request duckdb/duckdb#11790 from jzavala-gonzalez/python-write-parquet-options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a small snippet injecting a print into
connection.executeto log everyexecutethat gets executed, for debugging purposes.Fixed two tests:
test/sql/copy/csv/test_csv_timestamp_tz.testis expected to fail, but it succeeds because ICU is always present.test/sql/copy/csv/test_export_not_null.testwas actually broken, but a bug in the C++ API was hiding this.