Throw if non-VARCHAR key is passed to json_object - #19365
Merged
Merged
Conversation
duckdb-draftbot
marked this pull request as draft
October 13, 2025 10:56
lnkuiper
marked this pull request as ready for review
October 14, 2025 08:42
Collaborator
|
Thanks! |
2 tasks
github-actions Bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 21, 2025
Fixes for CTE (de)serialization compatibility with older versions (duckdb/duckdb#19393) BUGFIX: Silent failure to write row groups with large lists (duckdb/duckdb#19376) Throw if non-`VARCHAR` key is passed to `json_object` (duckdb/duckdb#19365) add test tag support [vfs integration tests p1] (duckdb/duckdb#19331)
github-actions Bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 21, 2025
Fixes for CTE (de)serialization compatibility with older versions (duckdb/duckdb#19393) BUGFIX: Silent failure to write row groups with large lists (duckdb/duckdb#19376) Throw if non-`VARCHAR` key is passed to `json_object` (duckdb/duckdb#19365) add test tag support [vfs integration tests p1] (duckdb/duckdb#19331) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19357
Now throws (just like SQLite3, which we copied the function from). Also changes some
InvalidInputExceptions toBinderExceptions, as they happen in the binder.