ADBC fix: escape schema, table and column identifiers - #19407
Merged
Merged
Conversation
duckdb-draftbot
marked this pull request as draft
October 15, 2025 13:12
evertlammerts
marked this pull request as ready for review
October 15, 2025 13:14
evertlammerts
marked this pull request as draft
October 15, 2025 13:20
Mytherin
marked this pull request as ready for review
October 15, 2025 18:28
duckdb-draftbot
marked this pull request as draft
October 16, 2025 07:13
evertlammerts
force-pushed
the
adbc_fix
branch
from
October 16, 2025 07:50
1dbff34 to
cc239df
Compare
evertlammerts
marked this pull request as ready for review
October 16, 2025 09:28
Collaborator
|
Thanks! |
github-actions Bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 21, 2025
v1.4: Only serialize CTE nodes when MATERIALIZED is specified (duckdb/duckdb#19420) ADBC fix: escape schema, table and column identifiers (duckdb/duckdb#19407)
github-actions Bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 21, 2025
v1.4: Only serialize CTE nodes when MATERIALIZED is specified (duckdb/duckdb#19420) ADBC fix: escape schema, table and column identifiers (duckdb/duckdb#19407) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly handle identifiers for
IngestionMode::CREATE