remove sha from artifacts - #19957
Merged
Merged
Conversation
github-actions Bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 1, 2025
[Fix] Bug in `FetchRow` after update on indexed table with `dict_fsst` compression (duckdb/duckdb#19970) Unbound index binding with context (duckdb/duckdb#19953) remove sha from artifacts (duckdb/duckdb#19957) [TestConfig] Fix `verify_fetch_row` config, reduce duplication in `skip_tests` (duckdb/duckdb#19967)
github-actions Bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 1, 2025
[Fix] Bug in `FetchRow` after update on indexed table with `dict_fsst` compression (duckdb/duckdb#19970) Unbound index binding with context (duckdb/duckdb#19953) remove sha from artifacts (duckdb/duckdb#19957) [TestConfig] Fix `verify_fetch_row` config, reduce duplication in `skip_tests` (duckdb/duckdb#19967) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for https://github.com/duckdblabs/duckdb-internal/issues/6712
current situation
As per PR: duckdb/duckdb#19881, the naming of the artifacts changed a bit for nightly builds.
The current situation is now as follows:
nightly triggered extension build
branch name 'v1.4-andium' ends up in the artifact name
duckdb_versionin artifact namemanually triggered extension build
duckdb_versionin artifact nameextensions in manually triggered release build
git_refis (typically) not set, sogithub.shais used in artifact nameduckdb_versionin artifact nameanalysis
For nightly builds,
"git_ref": "v1.4-andium"ends up in the name of the extension artifacts, while the process that downloads it expects the${{ github.sha }}to be in the name instead.The
${{ github.sha }}, however is not correct, as it is the duckdb sha of CI current run, and not necessarily the duckdb sha used while building the extension.solution
When downloading the extensions, we no longer filter on the
${{ github.sha }}, as it was not (always) meaningful anyway.