Conversation
Member
|
Hi @tianjq16, thanks for the PR, could you retag to v1.4, and fix the CI error? |
tianjq16
force-pushed
the
bugfix_incorrectly_remove_order_from_aggregates
branch
from
November 25, 2025 12:59
c8e3ddb to
232010d
Compare
Contributor
Author
Thanks for your reply! I have rebased this PR to the |
2 tasks
pdet
marked this pull request as draft
November 25, 2025 15:12
pdet
marked this pull request as ready for review
November 25, 2025 15:12
hawkfish
approved these changes
Nov 25, 2025
tianjq16
marked this pull request as draft
November 26, 2025 03:37
tianjq16
marked this pull request as ready for review
November 26, 2025 03:37
Collaborator
|
Thanks! |
github-actions Bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Nov 27, 2025
Fix optimizer incorrectly remove ORDER BY clause from aggregates (duckdb/duckdb#19925) No longer auto-enable profiling on DEBUG mode (duckdb/duckdb#19931)
github-actions Bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Nov 27, 2025
Fix optimizer incorrectly remove ORDER BY clause from aggregates (duckdb/duckdb#19925) No longer auto-enable profiling on DEBUG mode (duckdb/duckdb#19931) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #19924
When removing ORDER BY from aggregates, we need to check that the ORDER BY expression exists in each GroupingSet, not just whether it exists in the groups.