Support new v1.5 syntax for PEG grammar - #21172
Merged
Merged
Conversation
expressions as well
Dtenwolde
marked this pull request as draft
March 4, 2026 09:53
Dtenwolde
marked this pull request as ready for review
March 9, 2026 15:44
github-actions Bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 18, 2026
Date: 2026-03-11 15:22:28 +0100 [Fix] Memory error when transforming to `v1.0.0` ART storage (duckdb/duckdb#21270) Support new v1.5 syntax for PEG grammar (duckdb/duckdb#21172) Implement line number reporting in errors for PEG parser (duckdb/duckdb#21157)
github-actions Bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 18, 2026
Date: 2026-03-11 15:22:28 +0100 [Fix] Memory error when transforming to `v1.0.0` ART storage (duckdb/duckdb#21270) Support new v1.5 syntax for PEG grammar (duckdb/duckdb#21172) Implement line number reporting in errors for PEG parser (duckdb/duckdb#21157) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 22, 2026
Date: 2026-03-11 15:22:28 +0100 [Fix] Memory error when transforming to `v1.0.0` ART storage (duckdb/duckdb#21270) Support new v1.5 syntax for PEG grammar (duckdb/duckdb#21172) Implement line number reporting in errors for PEG parser (duckdb/duckdb#21157) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
krlmlr
added a commit
to krlmlr/duckdb-r-old
that referenced
this pull request
Mar 22, 2026
Date: 2026-03-11 15:22:28 +0100 [Fix] Memory error when transforming to `v1.0.0` ART storage (duckdb/duckdb#21270) Support new v1.5 syntax for PEG grammar (duckdb/duckdb#21172) Implement line number reporting in errors for PEG parser (duckdb/duckdb#21157) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
krlmlr
added a commit
to krlmlr/duckdb-r-old
that referenced
this pull request
Mar 22, 2026
Date: 2026-03-11 15:22:28 +0100 [Fix] Memory error when transforming to `v1.0.0` ART storage (duckdb/duckdb#21270) Support new v1.5 syntax for PEG grammar (duckdb/duckdb#21172) Implement line number reporting in errors for PEG parser (duckdb/duckdb#21157) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
kaka11chen
pushed a commit
to AstroVela/vane
that referenced
this pull request
Aug 14, 2026
Fixes https://github.com/duckdblabs/duckdb-internal/issues/7305 v1.5 introduced some new syntax: - [x] [Add partition by, sorted by, and extra options for create table statements](duckdb/duckdb#20431) - [x] [Support alter table set/reset options](duckdb/duckdb#20523) - [x] [Support Partitioned by, Sorted by, and With in CTAS statements](duckdb/duckdb#20728) (Still open at the time of writing) This PR adds support for the new grammar for the PEG Parser. For Alter `RESET` I added a more useful error message than the generic syntax error: ```sql -- PostgreSQL parser memory ⚫◗ ALTER TABLE tbl1 RESET ('foo'='baz'); Parser Error: "'baz'" ``` ```sql -- PEG parser memory ⚫◗ call enable_peg_parser(); ┌─────────┐ │ success │ │ boolean │ └─────────┘ 0 rows memory ⚫◗ ALTER TABLE tbl1 RESET ('foo'='baz'); Parser Error: Reset option "foo" cannot set any value. Did you mean to use SET? ``` Upstream-Commit: duckdb/duckdb@3c5c475
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/duckdblabs/duckdb-internal/issues/7305
v1.5 introduced some new syntax:
This PR adds support for the new grammar for the PEG Parser.
For Alter
RESETI added a more useful error message than the generic syntax error: