[Extensions] Preserve require order in InterpretedBenchmark - #21214
Merged
Mytherin merged 3 commits intoMar 7, 2026
Merged
Conversation
Collaborator
|
Thanks! |
github-actions Bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 9, 2026
Date: 2026-03-09 09:27:32 +0100 [Regression v1.5] Fix INTERNAL Error in UnnestRewriter for deeply nested struct UNNEST (duckdb/duckdb#21209) Restore view's bind_state when binding fails (duckdb/duckdb#21193) CLI: Make help entry uppercase (duckdb/duckdb#21224) [Extensions] Preserve `require` order in `InterpretedBenchmark` (duckdb/duckdb#21214) bump spatial (duckdb/duckdb#21206) Bump httpfs to better handle path normalization (curl backend) (duckdb/duckdb#21195)
github-actions Bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 9, 2026
Date: 2026-03-09 09:27:32 +0100 [Regression v1.5] Fix INTERNAL Error in UnnestRewriter for deeply nested struct UNNEST (duckdb/duckdb#21209) Restore view's bind_state when binding fails (duckdb/duckdb#21193) CLI: Make help entry uppercase (duckdb/duckdb#21224) [Extensions] Preserve `require` order in `InterpretedBenchmark` (duckdb/duckdb#21214) bump spatial (duckdb/duckdb#21206) Bump httpfs to better handle path normalization (curl backend) (duckdb/duckdb#21195) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
github-actions Bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 17, 2026
Date: 2026-03-09 09:27:32 +0100 [Regression v1.5] Fix INTERNAL Error in UnnestRewriter for deeply nested struct UNNEST (duckdb/duckdb#21209) Restore view's bind_state when binding fails (duckdb/duckdb#21193) CLI: Make help entry uppercase (duckdb/duckdb#21224) [Extensions] Preserve `require` order in `InterpretedBenchmark` (duckdb/duckdb#21214)
github-actions Bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 17, 2026
Date: 2026-03-09 09:27:32 +0100 [Regression v1.5] Fix INTERNAL Error in UnnestRewriter for deeply nested struct UNNEST (duckdb/duckdb#21209) Restore view's bind_state when binding fails (duckdb/duckdb#21193) CLI: Make help entry uppercase (duckdb/duckdb#21224) [Extensions] Preserve `require` order in `InterpretedBenchmark` (duckdb/duckdb#21214) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 22, 2026
Date: 2026-03-09 09:27:32 +0100 [Regression v1.5] Fix INTERNAL Error in UnnestRewriter for deeply nested struct UNNEST (duckdb/duckdb#21209) Restore view's bind_state when binding fails (duckdb/duckdb#21193) CLI: Make help entry uppercase (duckdb/duckdb#21224) [Extensions] Preserve `require` order in `InterpretedBenchmark` (duckdb/duckdb#21214) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
krlmlr
added a commit
to krlmlr/duckdb-r-old
that referenced
this pull request
Mar 22, 2026
Date: 2026-03-09 09:27:32 +0100 [Regression v1.5] Fix INTERNAL Error in UnnestRewriter for deeply nested struct UNNEST (duckdb/duckdb#21209) Restore view's bind_state when binding fails (duckdb/duckdb#21193) CLI: Make help entry uppercase (duckdb/duckdb#21224) [Extensions] Preserve `require` order in `InterpretedBenchmark` (duckdb/duckdb#21214) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
krlmlr
added a commit
to krlmlr/duckdb-r-old
that referenced
this pull request
Mar 22, 2026
Date: 2026-03-09 09:27:32 +0100 [Regression v1.5] Fix INTERNAL Error in UnnestRewriter for deeply nested struct UNNEST (duckdb/duckdb#21209) Restore view's bind_state when binding fails (duckdb/duckdb#21193) CLI: Make help entry uppercase (duckdb/duckdb#21224) [Extensions] Preserve `require` order in `InterpretedBenchmark` (duckdb/duckdb#21214) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
kaka11chen
pushed a commit
to AstroVela/vane
that referenced
this pull request
Aug 14, 2026
…db/duckdb#21214) Before this was using an `unordered_set` which does not have a defined order, and doesn't preserve any order either. This causes problems for extensions like `duckdb-iceberg`, which require `avro` and `parquet` to be loaded before `iceberg` itself gets loaded. ```sql require avro require parquet require iceberg require httpfs ``` Upstream-Commit: duckdb/duckdb@90de7de
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this was using an
unordered_setwhich does not have a defined order, and doesn't preserve any order either.This causes problems for extensions like
duckdb-iceberg, which requireavroandparquetto be loaded beforeicebergitself gets loaded.