Fix #21289: correctly determine render width of UTF8 string with grapheme clusters - #21409
Merged
Merged
Conversation
…h grapheme clusters
Closed
2 tasks
github-actions Bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 19, 2026
Date: 2026-03-17 07:50:12 +0100 Fix duckdb/duckdb#21289: correctly determine render width of UTF8 string with grapheme clusters (duckdb/duckdb#21409) Add lance extension (duckdb/duckdb#21406) Grab correct row group id in ValidityColumnData::UpdateWithBase (duckdb/duckdb#21397) add test for duckdb/duckdb#21271 (duckdb/duckdb#21398)
github-actions Bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 19, 2026
Date: 2026-03-17 07:50:12 +0100 Fix duckdb/duckdb#21289: correctly determine render width of UTF8 string with grapheme clusters (duckdb/duckdb#21409) Add lance extension (duckdb/duckdb#21406) Grab correct row group id in ValidityColumnData::UpdateWithBase (duckdb/duckdb#21397) add test for duckdb/duckdb#21271 (duckdb/duckdb#21398) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 22, 2026
Date: 2026-03-17 07:50:12 +0100 Fix duckdb/duckdb#21289: correctly determine render width of UTF8 string with grapheme clusters (duckdb/duckdb#21409) Add lance extension (duckdb/duckdb#21406) Grab correct row group id in ValidityColumnData::UpdateWithBase (duckdb/duckdb#21397) add test for duckdb/duckdb#21271 (duckdb/duckdb#21398) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
krlmlr
added a commit
to krlmlr/duckdb-r-old
that referenced
this pull request
Mar 22, 2026
Date: 2026-03-17 07:50:12 +0100 Fix duckdb/duckdb#21289: correctly determine render width of UTF8 string with grapheme clusters (duckdb/duckdb#21409) Add lance extension (duckdb/duckdb#21406) Grab correct row group id in ValidityColumnData::UpdateWithBase (duckdb/duckdb#21397) add test for duckdb/duckdb#21271 (duckdb/duckdb#21398) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
krlmlr
added a commit
to krlmlr/duckdb-r-old
that referenced
this pull request
Mar 22, 2026
Date: 2026-03-17 07:50:12 +0100 Fix duckdb/duckdb#21289: correctly determine render width of UTF8 string with grapheme clusters (duckdb/duckdb#21409) Add lance extension (duckdb/duckdb#21406) Grab correct row group id in ValidityColumnData::UpdateWithBase (duckdb/duckdb#21397) add test for duckdb/duckdb#21271 (duckdb/duckdb#21398) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
kaka11chen
pushed a commit
to AstroVela/vane
that referenced
this pull request
Aug 14, 2026
…heme clusters (duckdb/duckdb#21409) Fixes #21289 The issue came from a mis-aligned render width popping up due to `Utf8Proc::RenderWidth` not correctly taking grapheme clusters into account, when `BoxRenderer::TruncateValue` did correctly take them into account. Upstream-Commit: duckdb/duckdb@73ed005
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21289
The issue came from a mis-aligned render width popping up due to
Utf8Proc::RenderWidthnot correctly taking grapheme clusters into account, whenBoxRenderer::TruncateValuedid correctly take them into account.