Use regular pushdown path for semi/anti/left delim joins - #21416
Merged
Merged
Conversation
github-actions Bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 19, 2026
Date: 2026-03-17 18:11:20 +0100 Use regular pushdown path for semi/anti/left delim joins (duckdb/duckdb#21416) Fix invalid common subplan CTE reuse for issue duckdb/duckdb#21372 (duckdb/duckdb#21386)
github-actions Bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 19, 2026
Date: 2026-03-17 18:11:20 +0100 Use regular pushdown path for semi/anti/left delim joins (duckdb/duckdb#21416) Fix invalid common subplan CTE reuse for issue duckdb/duckdb#21372 (duckdb/duckdb#21386) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 22, 2026
Date: 2026-03-17 18:11:20 +0100 Use regular pushdown path for semi/anti/left delim joins (duckdb/duckdb#21416) Fix invalid common subplan CTE reuse for issue duckdb/duckdb#21372 (duckdb/duckdb#21386) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
krlmlr
added a commit
to krlmlr/duckdb-r-old
that referenced
this pull request
Mar 22, 2026
Date: 2026-03-17 18:11:20 +0100 Use regular pushdown path for semi/anti/left delim joins (duckdb/duckdb#21416) Fix invalid common subplan CTE reuse for issue duckdb/duckdb#21372 (duckdb/duckdb#21386) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
krlmlr
added a commit
to krlmlr/duckdb-r-old
that referenced
this pull request
Mar 22, 2026
Date: 2026-03-17 18:11:20 +0100 Use regular pushdown path for semi/anti/left delim joins (duckdb/duckdb#21416) Fix invalid common subplan CTE reuse for issue duckdb/duckdb#21372 (duckdb/duckdb#21386) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
kaka11chen
pushed a commit
to AstroVela/vane
that referenced
this pull request
Aug 14, 2026
…db#21416) Fixes duckdb/duckdb#21407 duckdb/duckdb#19152 introduces a special join filter pushdown optimizer for duplicate-eliminated joins, but this is not required for `LEFT / SEMI / ANTI` joins. We can use the regular join filter pushdown code for those joins. It is only required for `INNER` joins (currently) because the filter pushdown code for inner joins works by generating a cross product and using the cross product filter pushdown code. This then loses the delim join information which causes the plan to be incorrect. Upstream-Commit: duckdb/duckdb@5467da5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21407
#19152 introduces a special join filter pushdown optimizer for duplicate-eliminated joins, but this is not required for
LEFT / SEMI / ANTIjoins. We can use the regular join filter pushdown code for those joins. It is only required forINNERjoins (currently) because the filter pushdown code for inner joins works by generating a cross product and using the cross product filter pushdown code. This then loses the delim join information which causes the plan to be incorrect.