Conversation
hawkfish
self-requested a review
April 23, 2026 16:27
Mytherin
reviewed
Apr 23, 2026
|
|
||
| unique_ptr<icu::TimeZone> GetTimeZoneInternal(string &tz_str, vector<string> &candidates) { | ||
| tz_str = NormalizeTimeZone(tz_str); | ||
| auto tz = GetKnownTimeZone(tz_str); |
Collaborator
There was a problem hiding this comment.
NormalizeTimeZone already calls GetKnownTimeZone so this is doing double work now. Maybe this code should be cleaned up a bit?
Contributor
Author
There was a problem hiding this comment.
Thank you for your suggestion. Currently, the only function exposed externally is GetNormalizedTimeZone. Indeed, GetKnownTimeZone should no longer be called by any function other than GetNormalizedTimeZone.
tianjq16
force-pushed
the
bugfix_utc_timezone_cannot_be_parsed
branch
from
April 24, 2026 03:14
2caf3cb to
9102b00
Compare
duckdb-draftbot
marked this pull request as draft
April 24, 2026 03:14
tianjq16
marked this pull request as ready for review
April 24, 2026 03:15
Collaborator
|
Thanks! |
kaka11chen
pushed a commit
to kaka11chen/astrovela_vane
that referenced
this pull request
Aug 14, 2026
I noticed that DuckDB now supports timezones in the `UTC±NN00` format; however, this format can currently only be used within the `SET TIMEZONE= ` statement and cannot be used directly within queries. Therefore, I submit this patch to fix this issue. Upstream-Commit: duckdb/duckdb@f0413bf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that DuckDB now supports timezones in the
UTC±NN00format; however, this format can currently only be used within theSET TIMEZONE=statement and cannot be used directly within queries. Therefore, I submit this patch to fix this issue.