Pin the StatementType count in the C API - #26003
Merged
Merged
Conversation
The v2 C API surfaces StatementType under the same numeric values, but core had no count sentinel, so a member appended in core could only be caught by two runtime tests probing the values past the last known one. STATEMENT_TYPE_COUNT makes that a static_assert: appending a member shifts the count and fails to compile until the new type has an id in the v2 spec. The two probe tests are no longer needed.
evertlammerts
approved these changes
Sep 22, 2026
evertlammerts
left a comment
Member
There was a problem hiding this comment.
LGTM, with apologies for the long wait times for the test, this is much better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v2 C API surfaces StatementType under the same numeric values, but core had no count sentinel, so a member appended in core could only be caught by two runtime tests probing the values past the last known one.
STATEMENT_TYPE_COUNT makes that a static_assert: appending a member shifts the count and fails to compile until the new type has an id in the v2 spec. The two probe tests are no longer needed.
Originally first commit at #25990, but as pointed out better reviewed independently.
Newer version of #25972