Skip to content

cicd: add healthcheck to cli - #885

Merged
m8vago merged 2 commits into
developfrom
fix/cli-pipeline-issue
Nov 30, 2023
Merged

m8vago merged 2 commits into
developfrom
fix/cli-pipeline-issue

Conversation

@m8vago

@m8vago m8vago commented Nov 29, 2023 •

Copy link
Copy Markdown
Contributor

Add health probe after cli's up command to ensure the stack is ready.

@m8vago
m8vago requested a review from a team as a code owner November 29, 2023 15:49
@github-actions github-actions Bot added source:ci Workflow files pr:test labels Nov 29, 2023
@m8vago
m8vago force-pushed the fix/cli-pipeline-issue branch 6 times, most recently from 26dec90 to 8cf7ec9 Compare November 29, 2023 16:06
@github-actions github-actions Bot added source:web The scope of the issue or pull request is web. lang:typescript labels Nov 29, 2023
@m8vago
m8vago force-pushed the fix/cli-pipeline-issue branch 8 times, most recently from 738fe9a to 7eef976 Compare November 30, 2023 12:45
@github-actions github-actions Bot added source:cli The scope of the issue or pull request is CLI tool. lang:golang labels Nov 30, 2023
@m8vago
m8vago force-pushed the fix/cli-pipeline-issue branch 3 times, most recently from 962db14 to 8a88395 Compare November 30, 2023 14:26
@github-actions github-actions Bot removed source:web The scope of the issue or pull request is web. lang:typescript labels Nov 30, 2023
@m8vago
m8vago force-pushed the fix/cli-pipeline-issue branch 2 times, most recently from e476b64 to cbc0c77 Compare November 30, 2023 14:27
@m8vago m8vago changed the title test: e2e base url fix(build): add healthcheck to cli Nov 30, 2023
@m8vago m8vago changed the title fix(build): add healthcheck to cli fix(cicd): add healthcheck to cli Nov 30, 2023
@m8vago m8vago changed the title fix(cicd): add healthcheck to cli cicd: add healthcheck to cli Nov 30, 2023
@github-actions github-actions Bot added the pr:ci label Nov 30, 2023
@m8vago
m8vago force-pushed the fix/cli-pipeline-issue branch from cbc0c77 to 9702bc5 Compare November 30, 2023 14:35
@codecov-commenter

codecov-commenter commented Nov 30, 2023 •

Copy link
Copy Markdown

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (086da74) 26.14% compared to head (a601f4c) 25.99%.
Report is 1 commits behind head on develop.

Files Patch % Lines
golang/pkg/cli/container_defaults.go 0.00% 42 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #885      +/-   ##
===========================================
- Coverage    26.14%   25.99%   -0.15%     
===========================================
  Files           70       70              
  Lines         7440     7481      +41     
===========================================
  Hits          1945     1945              
- Misses        5341     5382      +41     
  Partials       154      154              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m8vago
m8vago force-pushed the fix/cli-pipeline-issue branch 2 times, most recently from 12a5375 to 3b74c42 Compare November 30, 2023 14:50
@m8vago
m8vago force-pushed the fix/cli-pipeline-issue branch from 3b74c42 to 8813029 Compare November 30, 2023 15:07
Comment thread .github/workflows/product_builder.yaml
Comment thread golang/pkg/cli/container_defaults.go Outdated
Comment thread golang/pkg/cli/container_defaults.go Outdated
Comment thread golang/pkg/cli/container_defaults.go
Comment thread golang/pkg/cli/container_defaults.go Outdated
Comment thread golang/pkg/cli/container_defaults.go Outdated
@m8vago
m8vago force-pushed the fix/cli-pipeline-issue branch 2 times, most recently from b07377a to 2bf4c32 Compare November 30, 2023 16:30
@m8vago
m8vago force-pushed the fix/cli-pipeline-issue branch from 2bf4c32 to a601f4c Compare November 30, 2023 16:35
@m8vago
m8vago merged commit 71bc355 into develop Nov 30, 2023
@m8vago
m8vago deleted the fix/cli-pipeline-issue branch November 30, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang:golang pr:ci pr:fix pr:test source:ci Workflow files source:cli The scope of the issue or pull request is CLI tool.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants