Skip to content

Fixed zlib dependency for Linux - #844

Open
ypopovych wants to merge 2 commits into
daltoniam:masterfrom
tesseract-one:master
Open

Fixed zlib dependency for Linux#844
ypopovych wants to merge 2 commits into
daltoniam:masterfrom
tesseract-one:master

Conversation

@ypopovych

@ypopovych ypopovych commented Oct 15, 2020

Copy link
Copy Markdown

Used the same approach as in SwiftNIO (C target with a linked native library).
If CommonCrypto dependency will be resolved can be compiled on Linux.

rinsuki added a commit to rinsuki/AUEtherCapture that referenced this pull request Mar 4, 2021
@rinsuki
Use patched version of StarScream
4273783 
daltoniam/Starscream#844
rinsuki added a commit to rinsuki/AUEtherCapture that referenced this pull request Mar 6, 2021
@rinsuki
AutoMuteUs Support (with auethermuteproxy) (#1)
da76cad 
* Add Socket.IO Official Client (it might not work in Windows)

* Use patched version of StarScream

daltoniam/Starscream#844

* Use forked version of Starscream

* update dependencies

* update dependencies

* remove socket.io client code

* WIP: support lobby, state, player event

* CI(Linux): Install libcurl-dev package

* CI(Linux): Use libcurl4-openssl-dev insteadof libcurl-dev

* Support gameend event & remove players after gameend/disconnect

* README: ✅ Linked with AutoMuteUs

* Add WindowsCompatibility.swift (sleep)
@danibachar danibachar mentioned this pull request May 11, 2021
Closed
@dmiluski

dmiluski commented Jul 22, 2021

Copy link
Copy Markdown

Hi folks, seeing if there was any update here?

@SammyAlvarado

SammyAlvarado commented Sep 22, 2021

Copy link
Copy Markdown

Sorry to ask but how do you edit the SwiftPM?

@danpalmer

danpalmer commented Oct 4, 2021

Copy link
Copy Markdown

@daltoniam hey is there anything blocking this? Can I/we help in getting this merged and released at all?

@raisameneses

raisameneses commented Dec 2, 2021

Copy link
Copy Markdown

Is this solution going to be merged ?

@canbalkaya

canbalkaya commented Mar 24, 2022

Copy link
Copy Markdown

Sorry to ask but how do you edit the SwiftPM?

Hey @SammyAlvarado. In order to edit SPM, you need to take it to the locally.

You can read this article: https://developer.apple.com/documentation/swift_packages/editing_a_package_dependency_as_a_local_package.

@johndpope

johndpope commented Sep 4, 2022 •
edited
Loading

Copy link
Copy Markdown

please merge.
the branch
Screen Shot 2022-09-04 at 10 18 54 am

the patched version seems broken
Screen Shot 2022-09-04 at 10 19 34 am

gh repo clone daltoniam/Starscream
Cloning into 'Starscream'...
remote: Enumerating objects: 3251, done.
remote: Counting objects: 100% (61/61), done.
remote: Compressing objects: 100% (45/45), done.
remote: Total 3251 (delta 28), reused 29 (delta 14), pack-reused 3190
Receiving objects: 100% (3251/3251), 2.68 MiB | 593.00 KiB/s, done.
Resolving deltas: 100% (1752/1752), done.
(base) ➜ test cd Starscream
(base) ➜ Starscream git:(master) gh pr checkout 844
remote: Enumerating objects: 13, done.
remote: Counting objects: 100% (7/7), done.
remote: Total 13 (delta 7), reused 7 (delta 7), pack-reused 6
Unpacking objects: 100% (13/13), 1.21 KiB | 103.00 KiB/s, done.
From https://github.com/daltoniam/Starscream

  • [new ref] refs/pull/844/head -> tesseract-one/master
    Switched to branch 'tesseract-one/master'

UPDATE
you can merge pr into own fork - or use mine - maybe use exact.

dependencies: [
.package(url: "https://github.com/wweevv-johndpope/Starscream.git", from: "4.0.4-fix")
],

This was referenced Sep 4, 2022
Closed
Closed
Closed
@cwiftdev

cwiftdev commented Nov 17, 2023

Copy link
Copy Markdown

Im using this library with swift Vapor framework and im getting an error about zlip dependency while deploying my application on Heroku. I need your helps guys. @daltoniam @johndpope

Ekran Resmi 2023-11-17 14 17 20

@zackliu zackliu mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@johndpope johndpope johndpope approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ypopovych @dmiluski @SammyAlvarado @danpalmer @raisameneses @canbalkaya @johndpope @cwiftdev