Repository navigation
proto: split running into create, load and start, pulling modules by digest - #41
Merged
Merged
Conversation
…digest Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Astra <noreply@openai.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the push upload of an app's module with a pull by digest, and splits running a task into three requests of the host.
exec_createnames the main module by its SHA-256 digest and returns the task id at once.exec_loadanswers once the Ark has fetched and checked every module of the task. The Ark asks the host for those modules through its ownexec_module_sizeandexec_module_readrequests.exec_startopens the owner's approval and answers once the owner approves.The three requests take the tags of
exec_upload_start,exec_upload_chunkandexec_sched, which are gone, and the module requests take 0x509 and 0x50a. Each message's comment states its contract, such as the 5s expiry between steps, the 30s per module request and the absence of an overall loading deadline. The design follows the apps spec in dark-bio/specs, where an app can use other apps pinned by digest.The library already routes any request of the Ark as it routes
relay_outbound, so no handwritten code changes, and the existing tests cover that routing. The firmware,arkand Ark Hub still speak the old messages and move over in changes of their own, Ark Hub with regenerated TypeScript bindings. The error codes of the new requests belong to the firmware, and the crate stays at 0.17.1 until its release.