Skip to content

TorchModel typing for fname argument in save is str, but is used as pathlib.PosixPath #1420

Open
Open
TorchModel typing for fname argument in save is str, but is used as pathlib.PosixPath#1420
Labels
bug

Description

@yurakuratov
yurakuratov
opened on Mar 24, 2021

fname argument of TorchModel.save() is expected to be str, but is actually used as pathlib.PosixPath
https://github.com/deepmipt/DeepPavlov/blob/master/deeppavlov/core/models/torch_model.py#L172

Support, please, both types of arguments or fix typing.

Activity

  1. yurakuratov
    added
    bug
    on Mar 24, 2021
  2. yurakuratov
    added a commit that references this issue on Mar 24, 2021

    fix: typing and fname usage in TorchModel.save/load, resolves #1420

    f1efeec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions