chore(glide.yaml): update minio-go to v1.0.0 release#74
Closed
mboersma wants to merge 2 commits into
Closed
Conversation
Member
|
Does this fix #70? Looks like they have an official, downloadable binary now |
Member
|
Also 💯 on upgrading the go-dev version. Glide 0.9 FTW |
Member
Author
|
There are some code changes still necessary: $ make build docker-build docker-push
mkdir -p ./rootfs/bin
docker run --rm -v /Users/matt/Projects/src/github.com/deis/minio:/go/src/github.com/deis/minio -w /go/src/github.com/deis/minio -e CGO_ENABLED=0 quay.io/deis/go-dev:0.8.0 go build -a -installsuffix cgo -ldflags '-s' -o ./rootfs/bin/boot boot.go || exit 1
# github.com/deis/minio/src/healthsrv
src/healthsrv/server.go:15: undefined: minio.CloudStorageClient
make: *** [build] Error 1Working on it... |
Member
|
@mboersma my bad, I misunderstood the scope of this PR. I see that you're upgrading the https://github.com/minio/minio-go library now. Let me know if I can help |
Member
|
wow, the above is a major facepalm moment for me. even the title says exactly what you're doing, and what I got wrong.... |
6730cc0 to
752f71d
Compare
752f71d to
e8ab2ad
Compare
|
|
||
| // Start starts the healthcheck server on $host:$port and blocks. It only returns if the server fails, with the indicative error | ||
| func Start(host string, port int, minioClient minio.CloudStorageClient) error { | ||
| func Start(host string, port int, minioClient minio.Client) error { |
Member
There was a problem hiding this comment.
would it be better to make this a pointer to *minio.Client so we don't have to de-reference the pointer at https://github.com/deis/minio/pull/74/files#diff-f6ee15f775b88714fe6122ff877b9e42R170?
e8ab2ad to
ab34742
Compare
Closed
Member
Author
|
Closing in favor of #79. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/minio/minio-go/releases/tag/v1.0.0
Also updates
go-devto:0.8.0to take advantage ofglideversion 0.9.0.