fix #780 - Update do.sh - #781
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Jenkins, add to testlist |
|
Hey, @drtamermansour can you add the line |
|
You'll also need to change the mode of the 'examples/stamps/do.sh' file. This can only be done at the command line (via |
|
I can not see a special format of the jenkins-build.sh file so I just added the line of code to the end of the file. Also I assume that you meant chmod |
|
Jenkins, test this please |
|
@drtamermansour can you paste in the checklist and fill it out? http://khmer.readthedocs.org/en/latest/dev/coding-guidelines-and-review.html#checklist |
|
Jenkins, test this please |
|
|
When I try: make doc test pep8 This is what I get: error: invalid command 'build_sphinx' Note: I am working on MSU-HPC using the virtual environment. I installed the dependencies and the make test passed ok |
|
Turns out that the HPCC used an old version of virtualenv; local upgrade fixed that. Next he ran into python-versioneer/python-versioneer#52 which he fixed via multiple |
|
ready for review |
There was a problem hiding this comment.
Oh, I just had an idea: if this test doesn't work there won't be a good indication of why
if you add || { echo examples/stamps/do.sh no longer runs; /bin/false } to the end of line 68 that will fix this.
|
ready for review |
There was a problem hiding this comment.
Wrapped lines should be indented to match the line above. In this instance you need three space before --savetable
|
Otherwise this is ready to merge |
|
@mr-c |
|
This passes 'make test' and 'make pep8' on my laptop; looks like Jenkins may be barfing on it. Jenkins, test this please. |
|
please test this |
|
I think you need to mention "Jenkins" in the test request |
|
|
|
Jenkins, test this please |
1 similar comment
|
Jenkins, test this please |
|
Thanks, @drtamermansour |
Fix #780 :In the do.sh script, the old argument --savehash has been updated to --savetable